docs: fix inaccurate non-terminal naming rules in GBNF README - #26489
Open
JingliangGao wants to merge 1 commit into
Open
docs: fix inaccurate non-terminal naming rules in GBNF README#26489JingliangGao wants to merge 1 commit into
JingliangGao wants to merge 1 commit into
Conversation
…rg#7720) The README claimed non-terminals are required to be dashed lowercase words, but grammar examples (e.g. c.gbnf) freely use camelCase names like dataType, relationOperator, argList, etc. Update the description to reflect actual behavior.
github-actions
Bot
added
the
documentation
|
Hi @JingliangGao, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7720
The README section on Non-Terminals claimed that rule names are required to be dashed lowercase words, but the grammar examples (e.g. c.gbnf) freely use camelCase names like dataType, relationOperator, argList, etc.
This PR updates the description to reflect actual GBNF behavior - non-terminals can contain letters, digits, hyphens, and underscores, and camelCase names work fine.
No code changes; documentation only.